Skip to content

add snippets for joins and explain - #973

Merged
morganchen12 merged 2 commits into
mc/pipelines-snippetsfrom
mc/more-pipelines
Jul 31, 2026
Merged

add snippets for joins and explain#973
morganchen12 merged 2 commits into
mc/pipelines-snippetsfrom
mc/more-pipelines

Conversation

@morganchen12

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new file snippets/firestore/pipeline.py containing various Cloud Firestore pipeline query snippets and a test data loader. A high-severity issue was identified in the pipeline_join_multi_field function, where the query filters on the field author instead of reviewer_id, creating a mismatch with the schema defined in the test data loader.

Comment thread snippets/firestore/pipeline.py Outdated
@morganchen12
morganchen12 merged commit c4ba7c0 into mc/pipelines-snippets Jul 31, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant